Add importExternalTexture test for video frame display size diff with coded size #4589
+136
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… coded size Validation error was thrown if the video frame's dispaly size was different with its coded size in importExternalTexture, because it used the visible size for copySize. This issue had been fixed by updating the copySize to reflect the coded size rather than the visible size, and add a test for this case, see crbug.com/471021591.
kainino0x
reviewed
Feb 11, 2026
Comment on lines
+450
to
+451
| displayWidth, | ||
| displayHeight, |
Collaborator
There was a problem hiding this comment.
We should also add a test that textureDimensions returns the correct value for textures like this. It might even make sense to make it part of the same test (or at least sharing much of the same code).
I think I'd like to go ahead and add this now, but if not, please add a TODO(#bugnumber).
| timestamp: 0, | ||
| }; | ||
|
|
||
| const frame = new VideoFrame(imageData.data.buffer, frameInit); |
Collaborator
There was a problem hiding this comment.
It would be ideal if we additionally had a version of this test where the frame comes from a video file instead of a VideoFrame. Mostly in case there are differences in the YUV codepaths, but also just to have a better chance of the test running on all browsers.
If this won't be easy (I don't know how hard it is) then just add a TODO(#bugnumber).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation error was thrown if the video frame's dispaly size was different with its coded size in importExternalTexture, because it used the visible size for copySize. This issue had been fixed by updating the copySize to reflect the coded size rather than the visible size, and add a test for this case.
Issue: https://crbug.com/471021591
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.