Skip to content

Conversation

@grcevski
Copy link
Contributor

The ability to set the SDK on top of OBI is there now and this particular change is dangerous, because it overrides the env variables for Alloy.

@grcevski grcevski requested a review from a team as a code owner November 18, 2025 15:45
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.76%. Comparing base (7cc5581) to head (0732c1b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2321      +/-   ##
==========================================
+ Coverage   43.30%   49.76%   +6.45%     
==========================================
  Files          38       38              
  Lines        2974     2970       -4     
==========================================
+ Hits         1288     1478     +190     
+ Misses       1573     1343     -230     
- Partials      113      149      +36     
Flag Coverage Δ
integration-test 16.75% <ø> (?)
k8s-integration-test 2.62% <ø> (?)
oats-test 0.00% <ø> (?)
unittests 43.23% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rafaelroquetto
Copy link
Contributor

I think you need to do a go mod tidy and a go mod vendor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants