add status in workflow runs#446
Open
summerguo-protectai wants to merge 2 commits intografana:mainfrom
Open
Conversation
|
|
itsmylife
requested changes
May 26, 2025
Contributor
itsmylife
left a comment
There was a problem hiding this comment.
@summerguo-protectai Thanks for the contribution. Could you please resolve the conflicts?
- Status field must be defined in here
github-datasource/src/types/query.ts
Lines 75 to 78 in ceb91ee
itsmylife
reviewed
Jul 25, 2025
Contributor
itsmylife
left a comment
There was a problem hiding this comment.
There are some issues in the code.
I commented one of them and the other is in models/client.go
GetWorkflowRuns's signature must be
GetWorkflowRuns(ctx context.Context, owner, repo, workflow string, branch string, status string, timeRange backend.TimeRange) ([]*googlegithub.WorkflowRun, error)
| var workflowRuns []*googlegithub.WorkflowRun | ||
| var err error | ||
| workflowRuns, page, err = client.getWorkflowRuns(ctx, owner, repo, workflow, "", timeRange, page) | ||
| workflowRuns, page, err = client.getWorkflowRuns(ctx, owner, repo, workflow, "", timeRange, page, runStatusCompleted) |
Contributor
There was a problem hiding this comment.
Suggested change
| workflowRuns, page, err = client.getWorkflowRuns(ctx, owner, repo, workflow, "", timeRange, page, runStatusCompleted) | |
| workflowRuns, page, err = client.getWorkflowRuns(ctx, owner, repo, workflow, "", runStatusCompleted, timeRange, page) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the ability to add status into the filter for get workflow runs. The purpose is to be able to alert on github action failures through Grafana.
This change is NOT tested.