Fix: don't try to retrieve credentials before we need them #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njvrzm
force-pushed
the
njvrzm/remove-preemptive-retrieve
branch
from
a0e8b96 to
a040c9a
Compare
idastambuk
approved these changes
May 27, 2025
njvrzm
force-pushed
the
njvrzm/remove-preemptive-retrieve
branch
2 times, most recently
from
47d6f7c to
597595b
Compare
This was causing an issue in Grafana Cloud. Also updates CHANGELOG for release
njvrzm
force-pushed
the
njvrzm/remove-preemptive-retrieve
branch
from
597595b to
8a9d409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing an issue in Grafana Cloud where the
externalIdrequest would try to get credentials without a full configuration, causing an timeout and error.Fixes grafana/athena-datasource#546 (partially)
Also updates CHANGELOG for release.