feat(helm): Add ability to toggle grpclb port for query frontend service #19609
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please run make helm-docs. |
GarnerBot
force-pushed
the
helm-query-frontend-lb-optional
branch
2 times, most recently
from
6487371 to
a9423d0
Compare
GarnerBot
force-pushed
the
helm-query-frontend-lb-optional
branch
from
a9423d0 to
6a02841
Compare
GarnerBot
force-pushed
the
helm-query-frontend-lb-optional
branch
from
6a02841 to
fe5cd89
Compare
GarnerBot
force-pushed
the
helm-query-frontend-lb-optional
branch
2 times, most recently
from
534a2cd to
917c35c
Compare
|
@trevorwhitney @Jayclifford345 @JStickler Note sure, it's worth to ping you. https://grafana.com/docs/loki/latest/setup/install/istio/ mentions that for istio installations, grpclb should be used. However, https://grpc.github.io/grpc/core/md_doc_load-balancing.html tell us that |
GarnerBot
force-pushed
the
helm-query-frontend-lb-optional
branch
from
9891770 to
9983a09
Compare
GarnerBot
force-pushed
the
helm-query-frontend-lb-optional
branch
from
9983a09 to
b888b9b
Compare
Signed-off-by: mlegris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows the grpc lb port to be toggled in the query frontend service. This is needed to use the helm chart with istio (https://grafana.com/docs/loki/latest/setup/install/istio/)
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR