Open
Conversation
ActiveRecord objects are compared by id only. The |= operator would ignore any children which are only updated, i.e. whose id has not changed. By reversing the `target = target | [child]` logic to `target = [child] | target`, we elect to keep the child with its updated attributes. This is relevant for detecting validation errors in the child later.
Collaborator
|
@carlobeltrame I just hopped in the ring to help here and am getting up to speed and sorting through these PRs and issues I haven't personally run into this problem and I'm not sure if I'm fully understanding what's going on, but getting the tests running and new ones added to illustrate the issue you're solving would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested validation errors on update operations are currently broken.
ActiveRecord objects are compared for equality by id only. The |= operator would ignore any children which are only updated, i.e. whose id has not changed. By reversing the
target = target | [child]logic totarget = [child] | target, we elect to keep the child with its updated attributes. This is relevant for detecting validation errors in the child later.Let me know if you generally approve of this change, so I can start investing time into writing tests for it.