Skip to content

Conversation

@PlayAnyData
Copy link
Contributor

Background

While the schema check is ignoring missing git information: https://github.com/graphql-hive/console/blob/main/packages/libraries/cli/src/commands/schema/check.ts#L232

Schema publish does not. Thus our pipelines fail due to missing git and stating author/commit cannot be found. https://github.com/graphql-hive/console/blob/main/packages/libraries/cli/src/commands/schema/publish.ts#L234

So if you do not provide an author nor a commit this will otherwise fail.

Description

Adding git to docker image

While the schema check is ignoring missing git information: https://github.com/graphql-hive/console/blob/main/packages/libraries/cli/src/commands/schema/check.ts#L232

Schema publish does not. Thus our pipelines fail due to missing git and stating author/commit cannot be found. 
https://github.com/graphql-hive/console/blob/main/packages/libraries/cli/src/commands/schema/publish.ts#L234
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @PlayAnyData, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where the schema publish command within the GraphQL Hive CLI was unable to execute successfully in CI/CD pipelines. The root cause was the omission of the git executable from the CLI's Docker image, which schema publish requires to retrieve author and commit information. By integrating git into the Docker build process, this change ensures that schema publish can now function as intended, preventing pipeline failures and streamlining the schema publishing workflow.

Highlights

  • Fixing Schema Publish Failures: The schema publish command in the GraphQL Hive CLI was failing in pipelines due to the absence of git within its Docker environment, unlike schema check which ignores missing git information.
  • Docker Image Update: The cli.dockerfile has been updated to include the git package, resolving the dependency issue for schema publish.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds git to the CLI's Docker image, which is necessary for the schema:publish command to function correctly by inferring commit and author information. The change is straightforward and addresses the problem described. I have provided one suggestion to optimize the final Docker image size by following common best practices.

@n1ru4l
Copy link
Contributor

n1ru4l commented Dec 4, 2025

@PlayAnyData Thank you for the PR, we will review shortly. In the meantime, to unblock yourself, you could pass --commit and --author as explicit flags to the docker container from the host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants