-
Notifications
You must be signed in to change notification settings - Fork 122
dockerfile for cli needs to include git #7369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
While the schema check is ignoring missing git information: https://github.com/graphql-hive/console/blob/main/packages/libraries/cli/src/commands/schema/check.ts#L232 Schema publish does not. Thus our pipelines fail due to missing git and stating author/commit cannot be found. https://github.com/graphql-hive/console/blob/main/packages/libraries/cli/src/commands/schema/publish.ts#L234
Summary of ChangesHello @PlayAnyData, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds git to the CLI's Docker image, which is necessary for the schema:publish command to function correctly by inferring commit and author information. The change is straightforward and addresses the problem described. I have provided one suggestion to optimize the final Docker image size by following common best practices.
|
@PlayAnyData Thank you for the PR, we will review shortly. In the meantime, to unblock yourself, you could pass |
Background
While the schema check is ignoring missing git information: https://github.com/graphql-hive/console/blob/main/packages/libraries/cli/src/commands/schema/check.ts#L232
Schema publish does not. Thus our pipelines fail due to missing git and stating author/commit cannot be found. https://github.com/graphql-hive/console/blob/main/packages/libraries/cli/src/commands/schema/publish.ts#L234
So if you do not provide an author nor a commit this will otherwise fail.
Description
Adding git to docker image