-
Notifications
You must be signed in to change notification settings - Fork 122
enhance(sdk-rs): builder pattern #7379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ardatan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the Builder pattern for key components within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
hive |
8.13.0-alpha-20251205155813-22182f8b3e54ab5846702ec5e35e229ce790abd2 |
npm ↗︎ unpkg ↗︎ |
hive-apollo-router-plugin |
2.3.5-alpha-20251205155813-22182f8b3e54ab5846702ec5e35e229ce790abd2 |
npm ↗︎ unpkg ↗︎ |
hive-console-sdk-rs |
0.3.0-alpha-20251205155813-22182f8b3e54ab5846702ec5e35e229ce790abd2 |
npm ↗︎ unpkg ↗︎ |
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7379.hive-storybook.pages.dev |
e6e71be to
c954ee3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the builder pattern for SupergraphFetcher, PersistedDocumentsManager, and UsageAgent, which is a great enhancement for API ergonomics and future-proofing. The implementation is solid, but I have identified a few areas for improvement. My main concerns are a potential panic in one of the builders, a performance issue in regex compilation for validation, and a common design issue in the new builders related to retry policy configuration that could be confusing for users. I've provided specific comments with suggestions to address these points. Overall, this is a valuable change.
💻 Website PreviewThe latest changes are available as preview in: https://pr-7379.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
Breaking Changes to avoid future breaking changes, and better DX;
Switch to Builder pattern for
SupergraphFetcher,PersistedDocumentsManagerandUsageAgentstructs.Benefits;
Example;
newmethod;Example;