Update sbm_estimators.py #1070
Open
Update sbm_estimators.py #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug fix for size-one blocks with loops=False
Collaborator
|
hi @bokveizen, are you able to give edit access for maintainers on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See Issue #1055
See Pull Request #1056 (comment)
What does this implement/fix? Briefly explain your changes.
Expected Behavior
Any size-1 block should just have zero probability.
Actual Behavior
In
sbm_estimators.py,_calculate_block_pcalls_calculate_p, which divides zero whenblock.size = 0.This can happen when some block has size one and
loops=Falseis used.Adding
before Line 519 of
graspologic/graspologic/models/sbm_estimators.pyshould do the trick.