Skip to content

Conversation

@DanielCliftonGuardian
Copy link
Contributor

@DanielCliftonGuardian DanielCliftonGuardian commented Dec 15, 2025

What does this change?

Removes live feed accordion from all live blogs and adds necessary styles from the accordion to the key events carousel

Why?

Resolves #14912

Screenshots

Before After
before after
With pinned post before With pinned post after
before1 after1

@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Dec 15, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 15, 2025
No longer needed after removing accordion component
@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Dec 15, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 15, 2025
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Dec 15, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 15, 2025
@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Dec 15, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 15, 2025
@DanielCliftonGuardian DanielCliftonGuardian changed the title Remove live feed accordion Remove live feed accordion from liveblogs Dec 15, 2025
@DanielCliftonGuardian DanielCliftonGuardian marked this pull request as ready for review December 15, 2025 15:25
@github-actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@DanielCliftonGuardian DanielCliftonGuardian requested a review from a team December 16, 2025 16:37
@petternitter
Copy link

Could you share what this looks like after when a pinned post appears above the key events @DanielCliftonGuardian?

@DanielCliftonGuardian
Copy link
Contributor Author

Could you share what this looks like after when a pinned post appears above the key events @DanielCliftonGuardian?

I have added this to the screenshots @petternitter

@SiAdcock
Copy link
Contributor

Can we completely delete the Accordion component and associated stories now? It looks like this was the only example.

@DanielCliftonGuardian
Copy link
Contributor Author

Can we completely delete the Accordion component and associated stories now? It looks like this was the only example.

Good point. I've removed these files

@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Dec 23, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 23, 2025
@DanielCliftonGuardian DanielCliftonGuardian merged commit 76aa9d3 into main Dec 29, 2025
28 checks passed
@DanielCliftonGuardian DanielCliftonGuardian deleted the rem-live-feed-accordion branch December 29, 2025 10:12
@gu-prout
Copy link

gu-prout bot commented Dec 29, 2025

Seen on PROD (merged by @DanielCliftonGuardian 9 minutes and 28 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove collapsable Live Feed from all live blogs

4 participants