added feature flag for signup component #15027
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
7 tasks
There was a problem hiding this comment.
Pull request overview
This PR introduces a feature flag (hideNewsletterForSubscribers) to control whether the newsletter subscription check is performed, allowing the newsletter signup component to be shown regardless of a user's subscription status when the flag is disabled.
- Added
enableCheckparameter touseNewsletterSubscriptionhook with a default value oftrue - Connected the feature flag from the frontend config through the component chain
- Added comprehensive test coverage for the new feature flag behavior
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| dotcom-rendering/src/lib/useNewsletterSubscription.ts | Added enableCheck parameter to hook that skips API call and returns false when disabled |
| dotcom-rendering/src/lib/useNewsletterSubscription.test.ts | Added test coverage for feature flag enabled, disabled, and default behavior scenarios |
| dotcom-rendering/src/lib/renderElement.tsx | Passes the hideNewsletterForSubscribers switch to the newsletter component |
| dotcom-rendering/src/components/EmailSignUpWrapper.stories.tsx | Added story demonstrating the feature flag disabled state |
| dotcom-rendering/src/components/EmailSignUpWrapper.importable.tsx | Added hideNewsletterForSubscribers prop and passes it to the subscription hook |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dotcom-rendering/src/components/EmailSignUpWrapper.importable.tsx
Outdated
Show resolved
Hide resolved
mgosz-guardian
approved these changes
Dec 17, 2025
mgosz-guardian
left a comment
mgosz-guardian
left a comment
There was a problem hiding this comment.
LGTM. One question in the comment.
…nto 442-add-feature-flag-toggle-for-sign-up-component
github-actions
bot
removed
the
run_chromatic
georgerichmond
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
I'm handling the API call through the feature flag, and the feature flag is being passed from the frontend repo via the config.
Why?
We will look to add a feature flag to toggle to identity api call.
Reference PR
Ticket link
Reference Ticket link: #14889
Reference Subtask ticket link : #14890
Screenshots