Add count to product carousel #15031
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
oliverabrahams
changed the title
oliverabrahams
force-pushed
the
oa/navigation-arrows
branch
from
ae03857 to
1f51155
Compare
…te the navigation buttons to not control their own visibility.
oliverabrahams
force-pushed
the
oa/mobile-count-carousel
branch
from
659f258 to
6930ef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a count state to the carousel which counts which card is being shown.
Adds a count component which uses a react portal to populate the count of scrolled cards.
Adds a count to scrollable products carousel up to mobile medium and then showing the navigation buttons.
Currently the navigation buttons handle their own visibility for mobile. This adds the option to control the visibility from the portalNode for Articles.
Associated with these PRs #15025 #14968
Screenshots