Skip to content

Conversation

@simonbyford
Copy link
Contributor

@simonbyford simonbyford commented Dec 23, 2025

What does this change?

Does two things:

  1. sets the aspect ratio of the container for looping videos in articles by passing in containerAspectRatio. This follows on from Set aspect ratio of containers to prevent CLS #15029
  2. adds support for full-width self-hosted videos. Looping videos in articles should display at full-width. Looping videos on fronts should continue to display in a fixed-size box with letterboxing (i.e. not full-width)

Why?

Editorial have requested it. There is a precedent because this is how images currently behave in articles.

Screenshots

Before After
Screenshot 2025-12-23 at 12 06 51 Screenshot 2025-12-23 at 12 00 12

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

@simonbyford simonbyford changed the title Fix aspect ratio for looping videos in articles Support full-width looping videos in articles Dec 23, 2025
@simonbyford simonbyford marked this pull request as ready for review December 23, 2025 12:11
@github-actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@simonbyford simonbyford added the run_chromatic Runs chromatic when label is applied label Dec 23, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 23, 2025
@paperboyo
Copy link
Contributor

🎁🎄 Yay!

Just a useless naming thought: even though fronts were where the player was born, they are a special case (letter-boxed?), while the behaviour in articles after your PR is what’s normal and expected. Once we finally have different weightings (roles) there, it may not exactly be “full-width” either.

If it’s easier as is, I haven’t wrote this comment.

Merry Xmas!

@simonbyford
Copy link
Contributor Author

🎁🎄 Yay!

Just a useless naming thought: even though fronts were where the player was born, they are a special case (letter-boxed?), while the behaviour in articles after your PR is what’s normal and expected. Once we finally have different weightings (roles) there, it may not exactly be “full-width” either.

If it’s easier as is, I haven’t wrote this comment.

Merry Xmas!

Thanks @paperboyo! I like your suggestion and I've made the change here: 0f2b3b0

letterboxed is false in the default case, but true for fronts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants