Fix flakey tests where scan fails to find & label Test PR #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145 - the issue was caused by the slightly variable results returned by the GitHub API.
In all the tests in
FunctionalSpec, we create several test fixtures with the GitHub API, each created to be used once and thrown away:Before continuing on to the next step, which would be having Prout scan the repo for recently-merged PRs, we perform several checks to ensure that the GitHub API confirms the status of the merged PR:
prout/test/lib/Helpers.scala
Lines 180 to 195 in a710e34
However, looking a the differing logs produced by the failure & success cases in #145, it became apparent that even though we've checked the GitHub API.