onRetrieve for radios/checkboxes

[bucha]

Hi there,

in my current project I needed the onRetrieve-callback to be fired on radios and checkboxes as well. I realised, that you drop out of the function before calling the onRetrieve in case the radio or checkbox is being checked. Maybe you did this on purpose?

Cheers,
Alex

[guillaumepotier]

Hi,

Thanks for your PR.

I was not intentional I think. And you're right, callback should be called even on radios/checkboxes elems.

Though, instead of duplicating the line and its comment (you have some problems with indent. Careful, I use 2 spaces soft tab..), maybe it would be better to add this line here just after the returnValue retrieval and conflict manager, and just before dealing with input type.

What do you think ?

Best

[chibicode]

This would be helpful...thanks :)

[guillaumepotier]

Hi there,

Sorry for looking that one so late.. Could you please rebase your commits (maybe squash them eventually?) and add a small test for that in test suite ?

Thanks a lot

[felixln]

didn't this merge yet? I just need the onRetrieve function for checkbox in my current project.

[nicti]

Will this ever be merged?

[guillaumepotier]

Hi there,

This current PR won't be merged since it is too far from master and have many conflicts. Since I do not have time and resource to update/maintain Garlic, please just make another PR with the fixes (no need for tests or documentation) and I would gladly merge it

Best