feat: fix 7d ttl, remove helm2, update helm #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
genisd
commented
Nov 3, 2025
genisd
commented
- feat: remove helm2. use newest helm ttl plugin. update helm
- feat: remove helm2 references. update alpine && helm
genisd
changed the title
genisd
force-pushed
the
pf-3133-fix-backend-7d-ttl
branch
10 times, most recently
from
f8bdf37 to
99405c6
Compare
Changes: - Remove Helm 2 binary installation and initialization from Dockerfile - Upgrade Helm 3 from v3.13.3 to v3.19.0 - Update helm-release-plugin to latest version (438a761) - Remove all Helm 2 compatibility code from index.js: - Simplify deleteCmd() to only support Helm 3 syntax - Remove conditional checks for helm === 'helm3' - Always set Helm 3 environment variables (XDG_*) - Modernize Kubernetes API usage: - Update Ingress from deprecated extensions/v1beta1 to networking.k8s.io/v1 - Add pathType: Prefix and update backend format for Ingress resources - Update test suite for Helm 3: - Remove Helm 2 version test from CI workflow - Update helm template command to use Helm 3 syntax (positional args) - Regenerate test expectations with Helm 3 output format - Update documentation: - Remove Helm 2 version references - Update helm parameter description to reflect Helm 3-only support - Update TTL parameter docs (remove 'only works with helm3' note) - Update version to v3.19.0 - Bump Docker image tag from v3 to v4 in production workflow refactor: remove canary deployment support Canary deployments are not being used, so removing all related logic to simplify the codebase. Changes: - Remove removeCanary input parameter and logic from index.js - Remove special handling for track === 'canary' - Remove canary test scenarios (canary.sh, canary.sh.snap) - Update test snapshots to remove removeCanary debug output - Remove canary deployment documentation from README - Update description to remove canary deployment mention
genisd
force-pushed
the
pf-3133-fix-backend-7d-ttl
branch
from
99405c6 to
40f9c1b
Compare
Added test scenarios: - timeout.sh: tests the timeout parameter - wait.sh: tests the wait parameter - timeout-wait.sh: tests timeout and wait together Updated existing snapshots to include the wait parameter debug output. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
fhp
reviewed
Nov 5, 2025
README.md
Outdated
| JSON encoded map. | ||
| - `helm`: Helm binary to execute (defaults to `helm`, which uses Helm 3. Currently only supported version). | ||
| - `version`: Version of the app, usually commit sha works here. | ||
| - `wait`: Time to wait for any individual Kubernetes operation like deployment pods. To be used in conjunction with wait (defaults to false. i.e. 5m) |
Member
There was a problem hiding this comment.
To be used in conjunction with wait
you meant timeout?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.