client app: added common udp_wait_readready function #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
commented
Jun 2, 2021
| timeout_at = client_enqueue_rq_at; | ||
|
|
||
| if (timeout_at != INT64_MAX) { | ||
| int64_t delta = timeout_at - ctx.now->cb(ctx.now); |
Contributor
Author
There was a problem hiding this comment.
Here in case of client the connection context was used instead of the global ctx. Does it make any difference?
quicly_context_t *ctx = quicly_get_context(conn);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a duplicated code in the client application, which implements waiting for read-readiness on a UDP socket.
This code is combined into a single function to reduce code duplication and cognitive complexity.