Skip to content

[Invoices] Move deposited invoices into a state in aasm #11847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Invoices] Move deposited invoices into a state in aasm #11847

wants to merge 4 commits into from
+33 −0

Conversation

@rluodev
Copy link
Contributor

@rluodev rluodev commented Oct 12, 2025

Summary of the problem

Centralizing the columns!

Describe your changes

Migrating data from current "deposited?" method into "aasm_state"'s "deposited_v2" state.

@rluodev rluodev requested a review from garyhtou October 12, 2025 21:58
@rluodev rluodev self-assigned this Oct 12, 2025
@rluodev rluodev requested a review from a team as a code owner October 12, 2025 21:58
@rluodev rluodev linked an issue Oct 12, 2025 that may be closed by this pull request
Invoice: Fix state management #4992
Open
@rluodev rluodev mentioned this pull request Oct 12, 2025
Open
sampoder
sampoder reviewed Oct 13, 2025
View reviewed changes
Copy link
Member

@sampoder sampoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for review?

garyhtou
garyhtou requested changes Oct 16, 2025
View reviewed changes
Copy link
Member

@garyhtou garyhtou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a one time job for data modifications instead of using a migration

garyhtou
garyhtou requested changes Oct 16, 2025
View reviewed changes
Copy link
Member

@garyhtou garyhtou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the code first to:

  1. Transition newly deposited invoices to deposited_v2
  2. Change all reads to use a method that considers both deposited? method and the deposited_v2 AASM state

After, we can then do this data migration.

@rluodev rluodev requested a review from a team as a code owner October 17, 2025 01:32
Luke-Oldenburg
Luke-Oldenburg reviewed Oct 20, 2025
View reviewed changes
db/migrate/20250918021841_migrate_invoice_states_to_aasm.rb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be deleted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampoder sampoder sampoder left review comments

@Luke-Oldenburg Luke-Oldenburg Luke-Oldenburg left review comments

@garyhtou garyhtou garyhtou requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@rluodev rluodev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invoice: Fix state management

4 participants

@rluodev @garyhtou @sampoder @Luke-Oldenburg