[Wise] Show more descriptive error message & fix CAD payout settings #11927
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedev132
approved these changes
Oct 24, 2025
Luke-Oldenburg
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
We don't want to re-process payout holdings that are no longer pending, however we're currently filtering out pending payout holdings with a scope, even though there's already code to filter them out in the job.
We're also not storing the Interac email, which can be ambiguous on the operations side and mess up our data if their HCB email address changes.
Describe your changes
This PR removes the
.pendingscope (which preventsActiveRecord::RecordNotFounderrors causing a 404) and does away with the "Use the same email for Interac?" checkbox.