-
Notifications
You must be signed in to change notification settings - Fork 7
Add reopen macro #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reopen macro #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a ?reopen macro that allows support team members to reopen closed tickets. The macro updates the ticket status in the database, notifies users that their ticket has been reopened, posts a message in the internal tickets channel, and updates reaction indicators on the original message.
Key changes:
- New
Reopenmacro class that handles ticket reopening logic - Modified message event handler to distinguish between reopen macro (for closed tickets) and other macros (for open tickets)
- Added the Reopen macro to the list of available macros
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| nephthys/macros/reopen.py | Implements the Reopen macro with database updates, user notifications, and internal messaging |
| nephthys/macros/init.py | Registers the Reopen macro in the macros list |
| nephthys/events/message.py | Updates message handling logic to route reopen macro to closed tickets and other macros to open tickets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! I've suggested two things (which you probably didn't do to avoid refactoring too much, tbf!)
The bot messages look great, and thanks for considering the edge cases with allowing macros on closed tickets :)
lmk if you have any questions about the requested changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
This adds a
?reopenmacro for support team members that allows for (only closed) tickets to be reopened.Reopening tickets sends a user-facing message saying that the ticket has been reopened, and also sends a message in the internal tickets channel.