Proper fix for deleting messages in the backend channel #78
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Yeah turns out deleting impersonated messages still works with a bot token - Partially reverts hackclub#74
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where messages were not being deleted properly from the ticket channel by removing the conditional impersonation logic and implementing proper message deletion based on workspace admin permissions.
Key Changes:
- Removed the
use_impersonationcheck that prevented setting username and icon_url - Added conditional message deletion logic based on admin availability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| nephthys/events/message.py | Removed use_impersonation logic to always set username and icon_url for ticket messages |
| nephthys/actions/resolve.py | Added conditional message deletion using either queue-based or direct deletion depending on admin permissions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@transcental you were right about not needing the use_impersonation check :P
@deoshreyas this fixes the bug we were having with messages not being deleted from the tickets channel :)