Skip to content

Fix ship certifier authorization for block/unblock recertification #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2025
Merged

Fix ship certifier authorization for block/unblock recertification #1206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f60359
give back Fraud team access to everything they had before PR
dhamariT Oct 3, 2025
958584a
invert authorization logic.
dhamariT Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/controllers/admin/users_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,16 +313,16 @@ def revoke_fraud_reviewer
private

def ensure_authorized_user
# Allow admins and fraud team full access
# Admins and fraud team have full access to all actions
return if current_user&.is_admin? || current_user&.fraud_team_member?

# Ship certifiers can only access recertification blocking actions
if current_user&.ship_certifier?
allowed_actions = %w[show block_recertification unblock_recertification]
redirect_to(root_path, alert: "whomp whomp") unless allowed_actions.include?(action_name)
else
redirect_to root_path, alert: "whomp whomp"
return if allowed_actions.include?(action_name)
end

redirect_to root_path, alert: "whomp whomp"
end

def fetch_hackatime(email)
Expand Down