Bring back cookieconsent #2606
Merged
Bring back cookieconsent #2606
+66
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Some screenshots: 
|
It was removed during the transition to VitePress. We do need to add it back given the structure of the site. The old plugin is back, but with some changes: - instead of static banner at top, it is a floating box on the bottom right - a custom CSS override was added to adapt the theming of the box to VitePress - make translatable by adding a locale-specific head that imports the JS file with a hack to add custom parameters for the message content - minor rice For now this is only added to the English page. As the translations for it start to fill, we can enable for remaining languages.
lifehackerhansol
force-pushed
the
cookieconsent-vitepress
branch
from
0b339ee to
6ca1f4d
Compare
lifehackerhansol
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was removed during the transition to VitePress. We do need to add it back given the structure of the site.
The old plugin is back, but with some changes:
For now this is only added to the English page. As the translations for it start to fill, we can enable for remaining languages.