-
Notifications
You must be signed in to change notification settings - Fork 16
Feat/BBND-1249_add_full_redeem_to_web #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Luigi Navarro <[email protected]>
…eeDividend views Signed-off-by: Luigi Navarro <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
|
||
| return useMutation((request: FullRedeemAtMaturityRequest) => SDKService.fullRedeemAtMaturity(request), { | ||
| onSuccess: (data) => { | ||
| if (data === true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we only need to validate a truthy response, we can simplify this to if (data).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, changed!
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]> Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Luigi Navarro [email protected]
Description
[ATS-WEB] Add a checkbox in force redeem view to redeem every tokens if the maturity date has arrived and add balance in seeCoupons and seeDividend views
[ATS-SDK] Add tokenBalance and decimals to getCouponFor
Type of change
Testing
Run npm run test → All tests pass.
Open the web UI → Click Created Bond → Click operations→ Click Force Redeem → A checkbox for full redeem appears → Execute Full Redeem
Open the web UI → Click Created Bond → See Coupons list → Find an existing Coupon → Balance appears
Open the web UI → Click Created Equity → See Dividends list → Find an existing Dividend → Balance appears
Node version:
Checklist