Skip to content

Conversation

@luigi-io
Copy link
Contributor

@luigi-io luigi-io commented Dec 5, 2025

Signed-off-by: Luigi Navarro [email protected]

Description

[ATS-WEB] Add a checkbox in force redeem view to redeem every tokens if the maturity date has arrived and add balance in seeCoupons and seeDividend views
[ATS-SDK] Add tokenBalance and decimals to getCouponFor

Type of change

  • Bug fix 🐞
  • New feature [WEB] ✨
  • Breaking change [SDK] 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

Run npm run test → All tests pass.

Open the web UI → Click Created Bond → Click operations→ Click Force Redeem → A checkbox for full redeem appears → Execute Full Redeem

Open the web UI → Click Created Bond → See Coupons list → Find an existing Coupon → Balance appears

Open the web UI → Click Created Equity → See Dividends list → Find an existing Dividend → Balance appears

Node version:

  • 20
  • 22
  • 24

Checklist

  • Style Guidelines followed ✅
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Local Tests Pass ✅
  • Effective Tests Added ✔️
  • No reduction of Coverage

@luigi-io luigi-io requested review from a team as code owners December 5, 2025 19:41
@luigi-io luigi-io requested a review from pathornteng December 5, 2025 19:41
@hedera-eng-infrastructure
Copy link

hedera-eng-infrastructure commented Dec 5, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.


return useMutation((request: FullRedeemAtMaturityRequest) => SDKService.fullRedeemAtMaturity(request), {
onSuccess: (data) => {
if (data === true) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we only need to validate a truthy response, we can simplify this to if (data).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, changed!

Signed-off-by: Luigi Navarro <[email protected]>
@luigi-io luigi-io merged commit 3ca9939 into develop Dec 9, 2025
11 checks passed
@luigi-io luigi-io deleted the feat/BBND-1249_add_full_redeem_to_web branch December 9, 2025 13:55
M-Francia pushed a commit that referenced this pull request Dec 9, 2025
M-Francia pushed a commit that referenced this pull request Dec 10, 2025
M-Francia pushed a commit that referenced this pull request Dec 10, 2025
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants