Skip to content

Conversation

@LeahMarieBush
Copy link
Contributor

@LeahMarieBush LeahMarieBush commented Dec 2, 2025

Description

Asana task

This PR adds support for short versions in dev-portal. There is a partner PR that will be merged around the same time as this one for UDR here.

The main changes in this PR are as follows:

  • Adds short version regex in all the spots that the normal version regex is used
  • Adds tests for the short version

Testing

This PR needs to be tested with the changes for UDR. Without those changes, the ones in this PR will not work. You will need to locally run UDR and dev-portal to see these changes reflected.

First, do the steps in UDR:
UDR:

  1. Checkout leah/feat/short-version
  2. Go to vault and create a few new versions. You can do this by copying the latest version folder and pasting it and then changing the name. For testing the sorting, use a variety of version names (ex. v2.x, v3.x, v4.x (rc), v5.x (beta))
  3. Run npm run prebuild
  4. After that finishes, run npm run dev

Then do the steps in dev-portal:
Dev-portal:

  1. Checkout leah/feat/short-version
  2. In the .env file, change the UNIFIED_DOCS_API to http://localhost:8080
  3. Run npm start
  4. Go to http://localhost:3000 and click through the vault docs. Verify the new short versions are sorted properly with the existing versions and look as expected

@vercel
Copy link

vercel bot commented Dec 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
dev-portal Ready Ready Preview Comment Dec 4, 2025 4:58pm

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@LeahMarieBush LeahMarieBush marked this pull request as ready for review December 2, 2025 22:04
@LeahMarieBush LeahMarieBush requested review from a team and RubenSandwich and removed request for a team December 2, 2025 22:04
Copy link
Collaborator

@RubenSandwich RubenSandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@LeahMarieBush LeahMarieBush enabled auto-merge (squash) December 4, 2025 16:51
@LeahMarieBush LeahMarieBush merged commit 6ae64c6 into main Dec 4, 2025
9 checks passed
@LeahMarieBush LeahMarieBush deleted the leah/feat/short-version branch December 4, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants