Export node State to NotifyLeave callback #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node State was exported to the application in commit 1c2989e, but only the MergeDelegate is passed Node values with the State field initialized. The actual state of each node as tracked by the local memberlist is hidden from the application in the non-exported nodeState struct which embeds Node. Remove the State field from nodeState so that the State field on the embedded Node is instead used to track the node state. This has the effect of making the actual state of the node (Left vs. Dead) available to NotifyLeave callbacks as a pointer to the nodeState's embedded Node struct is passed to EventDelegate callbacks.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node State was exported to the application in #223, but only the MergeDelegate is passed Node values with the State field initialized. The actual state of each node as tracked by the local memberlist is hidden from the application in the non-exported nodeState struct which embeds Node. Remove the State field from nodeState so that the State field on the embedded Node is instead used to track the node state. This has the effect of making the actual state of the node (Left vs. Dead) available to NotifyLeave callbacks as a pointer to the nodeState's embedded Node struct is passed to EventDelegate callbacks.