Skip to content

fix underflow when clock is 0 #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbver wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix underflow when clock is 0 #751

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c552f6
fix underflow when clock is 0
mbver Nov 11, 2024
ef8aeba
current time means current!
mbver Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions serf/snapshot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,9 +347,9 @@ func (s *Snapshotter) processMemberEvent(e MemberEvent) {
// clock value. This is done after member events but should also be done
// periodically due to race conditions with join and leave intents
func (s *Snapshotter) updateClock() {
lastSeen := s.clock.Time() - 1
if lastSeen > s.lastClock {
s.lastClock = lastSeen
current := s.clock.Time()
if current > s.lastClock+1 {
s.lastClock = current - 1
s.tryAppend(fmt.Sprintf("clock: %d\n", s.lastClock))
}
}
Expand Down