This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Rebase be39b6d - select yum or apt-get in systemd-resolved #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brikis98
reviewed
Jun 17, 2021
Collaborator
brikis98
left a comment
brikis98
left a comment
There was a problem hiding this comment.
Thanks for the PR! Code changes LGTM, except for a couple tiny NITs. Once those are fixed, I can kick off tests.
| } | ||
|
|
||
| function has_yum { | ||
| [ -n "$(command -v yum)" ] |
Collaborator
There was a problem hiding this comment.
NIT: we follow the Google Bash style guide, so would you mind updating to [[ ]] instead of [ ]?
| echo iptables-persistent iptables-persistent/autosave_v6 boolean true | sudo debconf-set-selections | ||
| sudo apt-get install -y iptables-persistent | ||
| if has_apt_get; then | ||
| sudo apt-get update -y |
Collaborator
There was a problem hiding this comment.
NIT: Not related to this PR, but I think we want:
Suggested change
| sudo apt-get update -y | |
| sudo DEBIAN_FRONTEND=noninteractive apt-get update -y |
Without it, we may occasionally get an interactive prompt here, causing the build to hang on input.
| sudo apt-get update -y | ||
| echo iptables-persistent iptables-persistent/autosave_v4 boolean true | sudo debconf-set-selections | ||
| echo iptables-persistent iptables-persistent/autosave_v6 boolean true | sudo debconf-set-selections | ||
| sudo apt-get install -y iptables-persistent |
Collaborator
There was a problem hiding this comment.
NIT: Not related to this PR, but I think we want:
Suggested change
| sudo apt-get install -y iptables-persistent | |
| sudo DEBIAN_FRONTEND=noninteractive apt-get install -y iptables-persistent |
Without it, we may occasionally get an interactive prompt here, causing the build to hang on input.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #204 for tests.