Skip to content

Conversation

@sushan-suresh
Copy link

@sushan-suresh sushan-suresh commented Dec 17, 2025

Previously, the aws_rds_integration resource required replacement when modifying or attributes. This change adds in-place update support using the AWS RDS ModifyIntegration API.

Changes:

  • Add Update method to handle in-place modifications
  • Add waitIntegrationUpdated function for state polling
  • Remove RequiresReplace() from integration_name and data_filter
  • Add update timeout configuration (default 30m)
  • Add acceptance tests for update functionality
  • Update documentation to reflect updatable attributes

Fixes #40818

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.5 [email protected]


PR Summary

Title: Add update support for aws_rds_integration resource

Description:

Summary

Adds in-place update support for aws_rds_integration resource using the AWS RDS ModifyIntegration API.

Problem

Currently, changing integration_name or data_filter forces resource replacement, which is disruptive for zero-ETL integrations.

Solution

  • Implemented Update method calling ModifyIntegration API
  • Added waitIntegrationUpdated for polling integration status
  • Removed RequiresReplace() plan modifiers from updatable attributes

Changes

File Change
internal/service/rds/integration.go Added Update method, waitIntegrationUpdated function, update timeout
internal/service/rds/integration_test.go Added TestAccRDSIntegration_update test
website/docs/r/rds_integration.html.markdown Updated documentation

Updatable Attributes (now in-place)

  • integration_name
  • data_filter

Still Requires Replacement

  • source_arn
  • target_arn
  • kms_key_id
  • additional_encryption_context

Testing

  • Added acceptance test TestAccRDSIntegration_update
  • Ran acceptance tests locally

References

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

  Previously, the aws_rds_integration resource required replacement when
  modifying  or  attributes. This change
  adds in-place update support using the AWS RDS ModifyIntegration API.

  Changes:
  - Add Update method to handle in-place modifications
  - Add waitIntegrationUpdated function for state polling
  - Remove RequiresReplace() from integration_name and data_filter
  - Add update timeout configuration (default 30m)
  - Add acceptance tests for update functionality
  - Update documentation to reflect updatable attributes

  Fixes hashicorp#40818

  🤖 Generated with [Claude Code](https://claude.com/claude-code)

  Co-Authored-By: Claude Opus 4.5 <[email protected]>

  ---
  PR Summary

  Title: Add update support for aws_rds_integration resource

  Description:

  Summary

  Adds in-place update support for aws_rds_integration resource using the AWS RDS ModifyIntegration API.

  Problem

  Currently, changing integration_name or data_filter forces resource replacement, which is disruptive for zero-ETL integrations.

  Solution

  - Implemented Update method calling ModifyIntegration API
  - Added waitIntegrationUpdated for polling integration status
  - Removed RequiresReplace() plan modifiers from updatable attributes

  Changes

  | File                                         | Change                                                               |
  |----------------------------------------------|----------------------------------------------------------------------|
  | internal/service/rds/integration.go          | Added Update method, waitIntegrationUpdated function, update timeout |
  | internal/service/rds/integration_test.go     | Added TestAccRDSIntegration_update test                              |
  | website/docs/r/rds_integration.html.markdown | Updated documentation                                                |

  Updatable Attributes (now in-place)

  - integration_name
  - data_filter

  Still Requires Replacement

  - source_arn
  - target_arn
  - kms_key_id
  - additional_encryption_context

  Testing

  - Added acceptance test TestAccRDSIntegration_update
  - Ran acceptance tests locally

  References

  - Fixes hashicorp#40818
  - AWS API: https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_ModifyIntegration.html
@sushan-suresh sushan-suresh requested a review from a team as a code owner December 17, 2025 13:49
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. labels Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support update for aws_rds_integration

1 participant