-
Notifications
You must be signed in to change notification settings - Fork 9.9k
Add update support for aws_rds_integration resource modification #45632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sushan-suresh
wants to merge
3
commits into
hashicorp:main
Choose a base branch
from
sushan-suresh:issue-40818
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+151
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the aws_rds_integration resource required replacement when modifying or attributes. This change adds in-place update support using the AWS RDS ModifyIntegration API. Changes: - Add Update method to handle in-place modifications - Add waitIntegrationUpdated function for state polling - Remove RequiresReplace() from integration_name and data_filter - Add update timeout configuration (default 30m) - Add acceptance tests for update functionality - Update documentation to reflect updatable attributes Fixes hashicorp#40818 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> --- PR Summary Title: Add update support for aws_rds_integration resource Description: Summary Adds in-place update support for aws_rds_integration resource using the AWS RDS ModifyIntegration API. Problem Currently, changing integration_name or data_filter forces resource replacement, which is disruptive for zero-ETL integrations. Solution - Implemented Update method calling ModifyIntegration API - Added waitIntegrationUpdated for polling integration status - Removed RequiresReplace() plan modifiers from updatable attributes Changes | File | Change | |----------------------------------------------|----------------------------------------------------------------------| | internal/service/rds/integration.go | Added Update method, waitIntegrationUpdated function, update timeout | | internal/service/rds/integration_test.go | Added TestAccRDSIntegration_update test | | website/docs/r/rds_integration.html.markdown | Updated documentation | Updatable Attributes (now in-place) - integration_name - data_filter Still Requires Replacement - source_arn - target_arn - kms_key_id - additional_encryption_context Testing - Added acceptance test TestAccRDSIntegration_update - Ran acceptance tests locally References - Fixes hashicorp#40818 - AWS API: https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_ModifyIntegration.html
Contributor
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
Contributor
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
needs-triage
Waiting for first response or review from a maintainer.
service/rds
Issues and PRs that pertain to the rds service.
size/L
Managed by automation to categorize the size of a PR.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the aws_rds_integration resource required replacement when modifying or attributes. This change adds in-place update support using the AWS RDS ModifyIntegration API.
Changes:
Fixes #40818
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.5 [email protected]
PR Summary
Title: Add update support for aws_rds_integration resource
Description:
Summary
Adds in-place update support for aws_rds_integration resource using the AWS RDS ModifyIntegration API.
Problem
Currently, changing integration_name or data_filter forces resource replacement, which is disruptive for zero-ETL integrations.
Solution
Changes
Updatable Attributes (now in-place)
Still Requires Replacement
Testing
References
aws_rds_integration#40818Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Relations
Closes #0000
References
Output from Acceptance Testing