Fix tests for #13733 #13740
Merged
Fix tests for #13733 #13740
+111
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done because the --inventory-file option for Ansible is anticipated to be removed as of the ansible-core package version '2.23'.
chrisroberts
previously approved these changes
Nov 6, 2025
chrisroberts
reviewed
Nov 7, 2025
…on the ansible-core version
taru-garg-hashicorp
force-pushed
the
fix-test-ansible
branch
from
ae821ae to
dc373e4
Compare
Member
chrisroberts
left a comment
chrisroberts
left a comment
There was a problem hiding this comment.
These updates look great! Left a couple simplification suggestions and one note on a conditional that should be adjusted (or removed).
There was a problem hiding this comment.
Pull Request Overview
This PR fixes test failures introduced in #13733 by updating tests and implementation to handle ansible-core version detection alongside ansible version detection, and switches to the --inventory flag for ansible-core >= 2.19.
Key changes:
- Updates box_add test to use asterisk masking pattern for credentials in HTTP URLs
- Adds ansible-core version checking to the provisioner alongside existing ansible version checks
- Implements version-aware inventory argument selection (--inventory vs --inventory-file)
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/vagrant/action/builtin/box_add_test.rb | Updates credential masking pattern in HTTP URL test assertion |
| test/unit/plugins/provisioners/ansible/provisioner_test.rb | Adds test cases for ansible-core version checking and inventory argument selection based on version |
| plugins/provisioners/ansible/provisioner/host.rb | Makes gather_ansible_version accept package parameter for querying different ansible packages |
| plugins/provisioners/ansible/provisioner/guest.rb | Makes gather_ansible_version accept package parameter for querying different ansible packages |
| plugins/provisioners/ansible/provisioner/base.rb | Implements ansible-core version tracking and version-based inventory argument selection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing test failures in #13733