[H-5723] Stub a Figma-to-Panda POC #95
Conversation
lunelson
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
||
| ## TODOs | ||
|
|
||
| - [ ] establish coordinatedthe variables nomenclature in Figma |
There was a problem hiding this comment.
Possibly this? Wasn't sure what the @todo actually meant. I suspect this may now also be done post-pairing w/ CH?
| - [ ] establish coordinatedthe variables nomenclature in Figma | |
| - [ ] establish the variables nomenclature in Figma |
| node_modules | ||
| dist | ||
| *.log | ||
| .DS_Store |
There was a problem hiding this comment.
This doesn't matter in the labs dir, but for awareness in the main hash monorepo we try to avoid having nested ignore files, and define everything in the root .gitignore which we then selectively sync with our other ignore files (also in the root) which handle linting exceptions, etc. This helps us keep things manageable in the monorepo structure.
In this case these 3 of these 4 appear in the root .gitignore already, with the exception of the *.log command (which the existing root .config/**/*.log exclusion could simple be expanded to account for).
There was a problem hiding this comment.
We can aim for that, but I would say the upside of nested ignore files is that you keep the file closer to the relevant patterns it is ignoring, which makes it easier to understand what is being ignored where and why, and allows the patterns to be more targeted (e.g. absolute paths relative to the nested file)—plus you avoid potentially unclear (or eventually orphaned) patterns in the root file.
FTR there are currently 7 nested .gitignore files in hash other than the root one
There was a problem hiding this comment.
No disagreement on those points; IIRC this was a conscious architectural decision for least a couple of reasons, although likely more I'm forgetting:
- (At least at the time) not all of our ignore files supported existence outside of the root. Possibly still true but we haven't checked in years and the exact ignore files we have may even have changed since.
- We wanted to improve keeping our various ignore files in sync, and sharing elements between them (which was a real pain point).
Stray .gitignores may well have slipped in to the primary public monorepo, but I wanted to flag this as an explicit goal since I am aware it exists, and know you would otherwise not have context on it (yet).
This POC is for practical testing of figma variable export approaches, and for converging with Ciaran H on a variables and variations naming structure in Figma that we can rely upon for clean parsing to PandaCSS' theme configuration pattern
NOTE: a number of the files here were created by the
tsdowntemplate for React component libraries