Skip to content

Compatibility with GHC 9.8 and 9.10 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ysangkok merged 2 commits into from
Dec 18, 2024
Merged

Compatibility with GHC 9.8 and 9.10 #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c326b9
Compatibility with GHC 9.8 and 9.10
ysangkok Dec 17, 2024
822a0b1
CI: Exclude old GHCs on MacOS
ysangkok Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions .github/workflows/haskell.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,25 @@ jobs:
fail-fast: false
matrix:
os: [macos-latest, ubuntu-latest]
cabal: ["3.8"]
ghc: ["8.4.4", "8.6.5", "8.8.4", "8.10.7", "9.0.2", "9.2.6", "9.4.4"]
cabal: ["3.12"]
ghc: ["8.4.4", "8.6.5", "8.8.4", "8.10.7", "9.0.2", "9.2.8", "9.4.8", "9.6.6", "9.8.4", "9.10.1"]
exclude:
- os: macos-latest
ghc: "8.4.4"
- os: macos-latest
ghc: "8.6.5"
- os: macos-latest
ghc: "8.8.4"
- os: macos-latest
ghc: "8.10.7"
- os: macos-latest
ghc: "9.0.2"

runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v3
- uses: haskell/actions/setup@v2
- uses: actions/checkout@v4
- uses: haskell-actions/setup@v2
id: setup-haskell-cabal
with:
ghc-version: ${{ matrix.ghc }}
Expand All @@ -29,7 +40,7 @@ jobs:
run: |
cabal v2-update
cabal v2-freeze $CONFIG
- uses: actions/cache@v2.1.5
- uses: actions/cache@v4
with:
path: |
${{ steps.setup-haskell-cabal.outputs.cabal-store }}
Expand Down
9 changes: 8 additions & 1 deletion src/Data/Thyme/TrueName.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
{- }}} -}

decNames :: Dec -> [Name]{- {{{ -}
decNames dec = case dec of

Check warning on line 33 in src/Data/Thyme/TrueName.hs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 3.12, 9.4.8) 

Pattern match(es) are non-exhaustive
FunD _ _ -> []
ValD _ _ _ -> []
TySynD _ _ typ -> typNames typ
Expand Down Expand Up @@ -65,7 +65,9 @@
PatSynSigD _name typ -> typNames typ
#endif

#if MIN_VERSION_template_haskell(2,8,0)
#if MIN_VERSION_template_haskell(2,22,0)
InfixD _ _ _ -> []
#elif MIN_VERSION_template_haskell(2,8,0)
InfixD _ _ -> []
#endif

Expand Down Expand Up @@ -123,6 +125,11 @@
ImplicitParamBindD _ _ -> []
#endif

#if MIN_VERSION_template_haskell(2,22,0)
TypeDataD _ _ _ _ -> []
DefaultD _ -> []
#endif

{- }}} -}

datatypeNames :: Cxt -> [Con] -> [Name]
Expand Down
2 changes: 1 addition & 1 deletion thyme.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ library
old-locale >= 1.0,
random,
text >= 0.11,
template-haskell >= 2.7 && < 2.21,
template-haskell >= 2.7 && < 2.23,
time >= 1.4,
vector >= 0.9,
vector-th-unbox >= 0.2.1.0,
Expand Down
Loading