Add dcd_configure for dwc2 FIFO config #3358
Open
+58
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HiFiPhile <[email protected]>
Signed-off-by: HiFiPhile <[email protected]>
HiFiPhile
commented
Nov 21, 2025
|
|
||
| // TX FIFO empty level for interrupt is complete empty | ||
| uint32_t gahbcfg = dwc2->gahbcfg; | ||
| gahbcfg |= GAHBCFG_TX_FIFO_EPMTY_LVL; |
Collaborator
Author
There was a problem hiding this comment.
I think there is no need to set FIFO level to complete empty in any case ?
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new configuration API (dcd_configure) to dynamically configure DWC2 device controller behavior, specifically enabling double buffering for IN endpoints to improve throughput. The implementation replaces the previous hardcoded TX FIFO empty level configuration with a configurable double buffering approach.
Key changes:
- New public API
tud_configure()to configure device stack behavior before initialization - DWC2-specific configuration structure to specify which IN endpoints should be double buffered
- FIFO allocation logic updated to support double buffering based on configuration
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/device/usbd.h | Adds new configuration API types and tud_configure() function declaration |
| src/device/usbd.c | Implements tud_configure() as a passthrough to dcd_configure() with weak default implementation |
| src/device/dcd.h | Declares dcd_configure() for device controller drivers to implement |
| src/portable/synopsys/dwc2/dcd_dwc2.c | Implements dcd_configure() for DWC2 and updates FIFO allocation logic to support double buffering; removes hardcoded TX FIFO empty level setting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Zixun LI <[email protected]>
Size Difference ReportBecause TinyUSB code size varies by port and configuration, the metrics below represent the averaged totals across all example builds. Changes >1% in any sectionNo entries. Changes <1% in all sections
No changes
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Add dcd_configure to configure dwc2 IN EP double buffer.
Although the gain is minimal as bandwidth limit is close (29MB/s vs 31MB/s). My PC's host controller only does 8 transfer per msof which yields a maximum throughput of 32MB/s.