dcd/rusb2: fix fifo write #3407
Merged
+19
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HiFiPhile <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a FIFO write bug in the RUSB2 USB device controller driver and enables dedicated hardware FIFO support. The fix addresses data corruption issues that could occur when writing from a circular buffer (tu_fifo) that wraps around, ensuring proper 16-bit alignment for hardware FIFO writes.
Key changes:
- Enables
CFG_TUD_EDPT_DEDICATED_HWFIFOfor RUSB2, indicating the hardware has dedicated FIFOs for each endpoint - Refactors
pipe_write_packet_ffto handle wrapped buffer writes with proper alignment by ensuring only the final write operation can have an odd byte count - When the linear portion of a wrapped buffer has odd length, creates a "glue" buffer combining the last byte of the linear portion with the first byte of the wrapped portion to maintain 16-bit alignment
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tusb_option.h | Enables CFG_TUD_EDPT_DEDICATED_HWFIFO for RUSB2 (tested on RA4M2-EK hardware) |
| src/portable/renesas/rusb2/dcd_rusb2.c | Fixes pipe_write_packet_ff to properly handle wrapped FIFO writes with 16-bit alignment requirements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Size Difference ReportBecause TinyUSB code size varies by port and configuration, the metrics below represent the averaged totals across all example builds. Note: If there is no change, only one value is shown. Changes >1% in size
Changes <1% in size
No changes
|
hathach
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a RA4M2-EK from no where, turns out compatible with ra4m3_ek...