Skip to content

[CLC-365] Makes sure map proxy is created in map commands #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yuce merged 3 commits into from
Sep 26, 2023
Merged

[CLC-365] Makes sure map proxy is created in map commands #400

yuce merged 3 commits into from
Sep 26, 2023

Conversation

@yuce
Copy link
Collaborator

@yuce yuce commented Sep 25, 2023

No description provided.

@netlify
Copy link

netlify bot commented Sep 25, 2023 •
edited
Loading

✅ Deploy Preview for eclectic-sawine-19fcf1 canceled.

Name Link
🔨 Latest commit d279b0e
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-sawine-19fcf1/deploys/6511f8334f77720008a672f2

@yuce yuce requested a review from kutluhanmetin September 25, 2023 08:47
kutluhanmetin
kutluhanmetin previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@kutluhanmetin kutluhanmetin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but tests needs to be fixed.

@yuce
Copy link
Collaborator Author

yuce commented Sep 25, 2023

@kutluhanmetin The LoadAllX methods of the Go client have a bug, fixed it at:
hazelcast/hazelcast-go-client#977

@yuce yuce added this to the 5.3.4 milestone Sep 25, 2023
@yuce yuce changed the title Makes sure map proxy is created in map commands [CLC-365] Makes sure map proxy is created in map commands Sep 25, 2023
@yuce yuce requested a review from kutluhanmetin September 25, 2023 21:31
@yuce
Copy link
Collaborator Author

yuce commented Sep 25, 2023

@kutluhanmetin I've reverted the change on map load-all instead of using the Go client Map.LoadAllX in order to merge this PR sooner.

@yuce yuce merged commit 71746a3 into hazelcast:main Sep 26, 2023
@yuce yuce deleted the fix/map-proxy branch September 26, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kutluhanmetin kutluhanmetin kutluhanmetin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.3.4

Development

Successfully merging this pull request may close these issues.

2 participants

@yuce @kutluhanmetin