Skip to content

Conversation

@emreyigit
Copy link
Member

@emreyigit emreyigit commented Dec 5, 2025

As part of 5.6.0 release, merge maintenance branch which contains the release tag to master.

emreyigit and others added 9 commits November 18, 2025 16:19
This PR upgrades `System.Linq.Async` and `System.Linq.Async.Queryable`
to resolve clashes on .NET10 runtime.


### Note to `netstandart2.0` users on .NET10 runtime;
`Hazelcast.Net` package has some poly fills to adapt some features on
legacy framework. This is presented over `netstandart2.0` target.
However, if you are running `netstandart2.0` built over .NET10 runtime,
you should override the transient dependency `Microsoft.Bcl.Memory`
package which comes with `Hazelcast.Net.Linq.Async` to escape from any
clashes on .NET10 runtime.

In your `csproj` file;
```
  <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
    <PackageReference Include="Microsoft.Bcl.Memory" Version="10.0.0" Aliases="MicrosoftBclMemory" />
  </ItemGroup>
  
  <Target Name="_SetAliasOnBuiltInSystemMemory" BeforeTargets="ResolveAssemblyReferences">
    <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
      <Reference Condition="'%(Reference.AssemblyName)' == 'Microsoft.Bcl.Memory'" Version="10.0.0">
        <Aliases>MicrosoftBclMemory</Aliases>
      </Reference>
    </ItemGroup>
  </Target>
```

We present the `netstandart2.0` target for legacy framework support as
intention of `netstandart2.0`. If you are trying to run it on modern
runtimes, please consider to target `netstandart2.1` or such as .NET10
for better performance and user experience.
Fix server condition issue detected during release testing, and fixed
the vector collection after run the tests properly.
The PR fixes vector vector search hint null failure. Also, Decreases
insatiability of `TestDelayedQueue` test by using atomic increment
instead ++ operation.
…` [HZ-5280] (#1021)

Added null check to prevent usage of `_subscribeTasks` during client
dispose.

closes #965 


The test output that helped to catch issue:
```
  Standard Output Messages:
 + Unobserved Exception:
 System.NullReferenceException: Object reference not set to an instance of an object.
    at Hazelcast.Clustering.ClusterEvents.AddSubscriptionsAsync(MemberConnection connection, IReadOnlyCollection`1 subscriptions, CancellationToken cancellationToken) in /home/runner/work/client-compatibility-suites/client-compatibility-suites/client/src/Hazelcast.Net/Clustering/ClusterEvents.cs:line 346
    at Hazelcast.Clustering.ClusterEvents.DisposeAsync() in /home/runner/work/client-compatibility-suites/client-compatibility-suites/client/src/Hazelcast.Net/Clustering/ClusterEvents.cs:line 1014
    at Hazelcast.Clustering.Cluster.DisposeAsync() in /home/runner/work/client-compatibility-suites/client-compatibility-suites/client/src/Hazelcast.Net/Clustering/Cluster.cs:line 219
```
closes #1018 

The `MemberRequest` and queue were using different time sources, that
was causing slightly differences in new runtimes due to their better
performance. Now, both are using same source, there is no differences
anymore.
The release action failed due to mis placed install action. It should be
called after checkout.
Merge the tag back to maintenance branch.

---------

Co-authored-by: GitHub Actions (Trigger Release) <[email protected]>
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.66%. Comparing base (fffe33b) to head (346ae8f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...t.Net/DistributedObjects/Impl/HVectorCollection.cs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
+ Coverage   81.44%   82.66%   +1.22%     
==========================================
  Files        1054     1054              
  Lines       25420    25429       +9     
==========================================
+ Hits        20703    21022     +319     
+ Misses       4717     4407     -310     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emreyigit emreyigit enabled auto-merge (squash) December 8, 2025 13:12
@emreyigit emreyigit changed the title Merge Back 5.6.z to master Merge 5.6.z back to master [HZ-5255][HZ-2336] Dec 8, 2025
@emreyigit emreyigit self-assigned this Dec 8, 2025
@emreyigit emreyigit added the Type: Backport Backport. label Dec 8, 2025
@emreyigit emreyigit requested a review from ihsandemir December 8, 2025 13:48
Copy link
Collaborator

@ihsandemir ihsandemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this merging not automated during release process? why did you need a PR for it? Is it in the release process document?

@emreyigit
Copy link
Member Author

The merging back operation is part of the release process. We do merge release branch to maintenance automatically but this one is not automatized yet.

@emreyigit emreyigit requested a review from ihsandemir December 9, 2025 07:56
@emreyigit emreyigit disabled auto-merge December 9, 2025 13:48
@emreyigit emreyigit merged commit 986832b into master Dec 9, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants