Fixes TestReliableTopicUnderStress and Error Log on Unsubscribing [HZ-5287][HZ-5266]
#1027
+78
−229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR;
Fixes the flakiness of
TestReliableTopicUnderStressby throwing operation cancelled while publishing in blocking policy. If the operation is cancelled during blocking publish, the API were doing nothing. Hence, test assumed that message is sent, and it was failing occasionally if the operation just cancelled before after API called. Java doesn't notify operation cancelled because it doesn't track the status.https://github.com/hazelcast/hazelcast-mono/blob/master/hazelcast/hazelcast/src/main/java/com/hazelcast/client/impl/proxy/ClientReliableTopicProxy.java#L148-L162
Decreased log level of operation cancelled logs which is written when the message executer is disposed. It happens when executer unsubscribed or client is disposed when there is a active subscription.
Refactored creating client options in the reliable topic test for better readability.
closes #971
closes #969