Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to customize the title field used for alias generation in the AliasFieldConfiguration class. Previously, the system always used the hardcoded 'title' field; now developers can specify an alternative field via the new setTitleField() method.
Changes:
- Added
titleFieldproperty andsetTitleField()method toAliasFieldConfigurationfor customizing the source field for alias generation - Renamed
aliasExistCallbacktogenerateAliasCallbackfor better naming consistency, with backward compatibility through a deprecated method - Updated dependency version constraints to support Symfony 7.0 and Doctrine DBAL 4.0
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Dca/AliasFieldConfiguration.php | Adds titleField property and setter method, renames callback property for clarity |
| src/EventListener/DcaField/AliasDcaFieldListener.php | Implements support for custom title field in alias generation logic, adds Contao 4/5 compatibility |
| src/Util/UserUtil.php | Removes unused imports (contains critical error) |
| src/EntityFinder/Finder.php | Removes obsolete phpstan ignore comment |
| src/EntityFinder/EntityFinderHelper.php | Fixes trailing newline formatting |
| rector.php | Updates configuration with better formatting and additional options |
| composer.json | Updates dependency versions for Symfony 7.0 and Doctrine DBAL 4.0 support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull Request Test Coverage Report for Build 21216089235Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.