Skip to content

Conversation

@Berkant03
Copy link
Collaborator

@Berkant03 Berkant03 commented Feb 24, 2025

Merge PR #1917 before this one!

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

Issue/s resolved: #1789

Changes proposed:

Add a Heat aware DistributedSampler for usage for PyTorch use cases

Update: Added a train_val_split function.

Type of change

  • New feature (non-breaking change which adds functionality)

Does this change modify the behaviour of other functions? If so, which?

no

@github-actions
Copy link
Contributor

Thank you for the PR!

@codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

❌ Patch coverage is 70.58824% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.62%. Comparing base (a7ff81d) to head (2d6353f).

Files with missing lines Patch % Lines
heat/utils/data/datatools.py 70.29% 60 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1807      +/-   ##
==========================================
- Coverage   91.96%   91.62%   -0.34%     
==========================================
  Files          88       88              
  Lines       13496    13697     +201     
==========================================
+ Hits        12411    12550     +139     
- Misses       1085     1147      +62     
Flag Coverage Δ
unit 91.62% <70.58%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Berkant03 Berkant03 added enhancement New feature or request memory footprint and removed memory footprint labels Feb 24, 2025
@ClaudiaComito ClaudiaComito added this to the 1.6 milestone Feb 24, 2025
@github-actions
Copy link
Contributor

Thank you for the PR!

1 similar comment
@github-actions
Copy link
Contributor

Thank you for the PR!

@github-actions
Copy link
Contributor

Thank you for the PR!

@Berkant03
Copy link
Collaborator Author

Berkant03 commented Mar 17, 2025

When using the normal comm.Bcast the Bcast only works the first time and the seconds time not anymore.

❯ mpirun -np 2 python test.py
0 tensor([2, 4, 3, 0, 1], dtype=torch.int32)
1 tensor([2, 4, 3, 0, 1], dtype=torch.int32)
...
1 tensor([455,   0,   0,   0,  32], dtype=torch.int32)
0 tensor([1, 4, 3, 2, 0], dtype=torch.int32)

@github-actions
Copy link
Contributor

Thank you for the PR!

…_DistributedSampler_for_Interoperability_with_Pytorch_Ecosystem
@github-actions
Copy link
Contributor

Thank you for the PR!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Thank you for the PR!

@github-actions
Copy link
Contributor

Thank you for the PR!

pre-commit-ci bot and others added 17 commits June 30, 2025 06:25
…_DistributedSampler_for_Interoperability_with_Pytorch_Ecosystem
…_DistributedSampler_for_Interoperability_with_Pytorch_Ecosystem
- Add Comments for init
- made idxmap creation faster
…mentation_of_a_Heat_Aware_DistributedSampler_for_Interoperability_with_Pytorch_Ecosystem' into features/1789-Implementation_of_a_Heat_Aware_DistributedSampler_for_Interoperability_with_Pytorch_Ecosystem
- remove randperm for correction
- Added Train, val split function using the sampler.
…_DistributedSampler_for_Interoperability_with_Pytorch_Ecosystem
…_DistributedSampler_for_Interoperability_with_Pytorch_Ecosystem
…ct_randomization_of_tests_set_seed_in_basic_test_case_class

set seed in basic test class
@JuanPedroGHM JuanPedroGHM modified the milestones: 1.6, 1.7.0 Aug 25, 2025
…_DistributedSampler_for_Interoperability_with_Pytorch_Ecosystem
@JuanPedroGHM JuanPedroGHM self-assigned this Oct 29, 2025
@github-actions
Copy link
Contributor

Thank you for the PR!

@JuanPedroGHM
Copy link
Member

TODO

  • __repr__ might have been a mistake, should return to previous behaviour 😢
  • Investigate difference between existing ht.random.permute and _alltoall_shuffle
  • Move SeedEnvironemnt to base test class. (Creation and teardown methods, possibly)

@github-project-automation github-project-automation bot moved this from In Progress to Merge queue in Roadmap Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Merge queue

Development

Successfully merging this pull request may close these issues.

Implementation of a Heat Aware DistributedSampler for Interoperability with Pytorch Ecosystem

5 participants