Set correct dtype when loading and saving hdf5 #2014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for the PR! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2014 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 88 88
Lines 13563 13571 +8
=======================================
+ Hits 12478 12486 +8
Misses 1085 1085
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thank you for the PR! |
…_hdf5_set_the_dtype_to_float32
ClaudiaComito
changed the title
Contributor
|
Thank you for the PR! |
…_hdf5_set_the_dtype_to_float32
Contributor
|
Thank you for the PR! |
ClaudiaComito
approved these changes
Nov 14, 2025
Contributor
ClaudiaComito
left a comment
ClaudiaComito
left a comment
There was a problem hiding this comment.
This looks great, thanks a lot @Marc-Jindra !
ClaudiaComito
deleted the
bugs/2004-_Bug_by_default_save_hdf5_and_load_hdf5_set_the_dtype_to_float32
branch
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2025
* fixed load_hdf5 * fixed save_hdf5 * fixed different behavior in tests * test torch dtype for save_hdf5 --------- Co-authored-by: Claudia Comito <[email protected]> (cherry picked from commit 678cd47)
Contributor
|
Successfully created backport PR for |
JuanPedroGHM
pushed a commit
that referenced
this pull request
Nov 17, 2025
* fixed load_hdf5 * fixed save_hdf5 * fixed different behavior in tests * test torch dtype for save_hdf5 --------- (cherry picked from commit 678cd47) Co-authored-by: Marc-Jindra <[email protected]> Co-authored-by: Claudia Comito <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due Diligence
Description
Until now, when saving a dndarray with
dtype=ht.int32usingsave_hdf5, the resulting h5 dataset has the typefloat32. This can be avoided by specifyingdtype=intordtype=np.int32(notht.int32ortorch.int32as those throw errors) but it should use the dtype of the dndarray by default.The same issue exists for
load_hdf5, where it does not use the type of the h5 dataset but sets it tofloat32.This PR resolves those issues, while also solving the issue of not being able to specify
dtype=ht.float32insave_hdf5.Issue/s resolved: #2004
Changes proposed:
Type of change
Bug fix (non-breaking change which fixes an issue)
Memory requirements
Performance
Does this change modify the behaviour of other functions? If so, which?
yes / no