Skip to content

Conversation

@sush67
Copy link

@sush67 sush67 commented Jun 14, 2021

Related Issue

  • Fixes - Added Firebase Analytics

Proposed Changes

  • Get to know users interaction, which in turn tells which feature is most liked
  • Handle errors by watching analytics data

Additional Information

  • Have added steps in comments as a part of the documentation, for enabling firebase analytics to a new screen or to any action. So that when this app grows analytics can also be extended.

Checklist

  • Tested
  • No Conflicts
  • Change In Code
  • Change In Documentation
  • Follows linting rules

Screenshots

Before this PR After this PR
** Original Screenshot ** ** Updated Screenshot **

Screenshot (799)
Screenshot (800)
Screenshot (801)
Screenshot (802)
Screenshot (803)
Screenshot (804)
Screenshot (805)
Screenshot (806)
Screenshot (807)
Screenshot (810)
Screenshot (811)
Screenshot (812)
Screenshot (813)
Screenshot (814)
Screenshot (815)

@welcome
Copy link

welcome bot commented Jun 14, 2021

Hello there!👋 Welcome to the project!💖
Thank you and congrats🎉 for opening your first pull request. Please make sure you have gone through our Code of Conduct and contributing files before making this pr. 🙌🙌 We will get back to you as soon as we can 😄.

@github-actions github-actions bot added the GSSOC21 Issues created for GSSOC'21 label Jun 14, 2021
@himanshusharma89 himanshusharma89 removed the GSSOC21 Issues created for GSSOC'21 label Sep 26, 2021
await _auth.signInWithEmailAndPassword(email: email, password: password);
} on FirebaseAuthException catch (e) {
String errorTemp;
await analyticsService.loginError(userId: UserDetails.uid);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How we will get the UID without login?

await _analytics.setUserId(userId);
}

}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to pass the userId for every function. Get the userId once and send it to analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants