Refactor migration publishing #199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing timestamped prefixes and registering them directly in the service provider using `hasMigrations`. Removed manual publishing and loading of migrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Why are these changes necessary ?
If somebody wants to rename the published migrations, the way they used to be loaded, it would cause the migrations to run twice since the name wouldn't match anymore.
According to the documentation publishing migrations is a required step anyway. (Quickstart - Verbs)
So there is no need to load the migrations within the package.
What was changed ?
The package uses the
PackageServiceProviderso instead of manually registering and loading the migrations, we usehasMigrationsinconfigurePackage().The migration files had the timestamp prefix removed too, since the spatie package adds those automatically.
Migrations can still be published using the same command
php artisan vendor:publish --tag=verbs-migrations