-
Notifications
You must be signed in to change notification settings - Fork 47
Add event map #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gehrisandro
wants to merge
1
commit into
hirethunk:main
Choose a base branch
from
gehrisandro:feat/event-map
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add event map #219
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <?php | ||
|
|
||
| namespace Thunk\Verbs\Exceptions; | ||
|
|
||
| use RuntimeException; | ||
| use Thunk\Verbs\Event; | ||
|
|
||
| class EventMapViolationException extends RuntimeException | ||
| { | ||
| /** | ||
| * The name of the affected event. | ||
| */ | ||
| public string $event; | ||
|
|
||
| /** | ||
| * Create a new exception instance. | ||
| * | ||
| * @param class-string<Event> $event | ||
| */ | ||
| public function __construct(string $event) | ||
| { | ||
| parent::__construct("No alias defined for event [{$event}]."); | ||
|
|
||
| $this->event = $event; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| <?php | ||
|
|
||
| use Thunk\Verbs\Event; | ||
| use Thunk\Verbs\Facades\Verbs; | ||
|
|
||
| it('can store and restore an event with and without alias', function () { | ||
| Event::eventMap([ | ||
| 'with-alias' => EventMapEventWithAlias::class, | ||
| ]); | ||
|
|
||
| EventMapEventWithAlias::fire(); | ||
| EventMapEvent::fire(); | ||
|
|
||
| Verbs::commit(); | ||
|
|
||
| [$eventWithAlias, $eventWithoutAlias] = \Thunk\Verbs\Models\VerbEvent::all(); | ||
|
|
||
| expect($eventWithAlias) | ||
| ->type->toBe('with-alias') | ||
| ->event()->toBeInstanceOf(EventMapEventWithAlias::class); | ||
|
|
||
| expect($eventWithoutAlias) | ||
| ->type->toBe(EventMapEvent::class) | ||
| ->event()->toBeInstanceOf(EventMapEvent::class); | ||
| }); | ||
|
|
||
| test('using an event without an entry in the event map throws an exception when event map is required', function () { | ||
| Event::eventMap([ | ||
| 'with-alias' => EventMapEventWithAlias::class, | ||
| ]); | ||
| EventMapEvent::requireEventMap(); | ||
|
|
||
| EventMapEvent::fire(); | ||
|
|
||
| Verbs::commit(); | ||
| }) | ||
| ->throws(\Thunk\Verbs\Exceptions\EventMapViolationException::class, 'No alias defined for event [EventMapEvent].') | ||
| ->after(fn () => EventMapEvent::requireEventMap(false)); | ||
|
|
||
| class EventMapEventWithAlias extends Event {} | ||
|
|
||
| class EventMapEvent extends Event {} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this should be public, and be on the
Eventabstract class. This is something that you would typically push into the service that handles event resolution, then from there it can be stored as a stateful, non-static property so that it can't get easily overwritten or altered outside of a service provider.I would feel a lot more comfortable if this was managed via the
Verbsservice, and exposed via theVerbsfacade, e.g.:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯, see my comment below.
My initial intention was to make it more similar to Laravel where the morph map is on the
Relationclass.