Potential fix for code scanning alert no. 2: Prototype-polluting function #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/hizzgdev/jsmind/security/code-scanning/2
To fix this issue, the merge function needs to block the assignment or merging of potentially dangerous special property names (
__proto__,constructor, and possiblyprototype). The best way to do this is to, inside the loop, skip any keys with those names before assigning or recursing. This can be achieved by adding a simple conditional check at the top of the loop. No external library is required; this can be done inline. Only the function body ofutil.json.merge(lines 75–92) insrc/jsmind.util.jsmust be changed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.