Potential fix for code scanning alert no. 3: Prototype-polluting function #687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/hizzgdev/jsmind/security/code-scanning/3
To fix the prototype pollution vulnerability, we must prevent the function from copying or merging properties with dangerous keys into the destination object. Specifically, block property names such as
"__proto__","constructor", and"prototype", as these can be used to pollute the JavaScript prototype chain. The best, least-disruptive fix is to add a check in the loop so that if the key matches any of those disallowed names, it skips copying or recursing on it.This change should be applied directly inside the
jm.util.json.mergefunction, right after the loop variable is defined in thefor (var o in a)loop. No new imports or project-wide changes are needed: just add a check likeif (o === '__proto__' || o === 'constructor' || o === 'prototype') continue;.Places to change:
js-legacy/jsmind.jsjm.util.json.mergeWe should insert the guard as soon as we enter the loop, before any assignment or recursion on
b[o]. No helper methods or other definitions are needed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.