Skip to content

Conversation

@rolan701
Copy link
Contributor

added pydentate into the main loop. Should there be no catoms passed, and the input was a smiles string, pydentate will pass in predicted catoms and structgen will automatically apply them

from pydentate import pydentate_lite
i = 0
for ligand in ligand_list:
if ligand[1] == None:

Check notice

Code scanning / CodeQL

Testing equality to None Note

Testing for None should use the 'is' operator.
mol2d = mol2d.from_smiles(ligands[i])
catoms = mol2d.denticity_hapticity(catoms)[2]
fixed_ligand_list.append((ligand[0],catoms,ligand[2],ligand[3]))
except:

Check notice

Code scanning / CodeQL

Except block handles 'BaseException' Note

Except block directly handles BaseException.
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.24%. Comparing base (6602be3) to head (709a6cd).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
molSimplify/__main__.py 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
- Coverage   40.27%   40.24%   -0.03%     
==========================================
  Files          93       93              
  Lines       29442    29464      +22     
==========================================
+ Hits        11857    11858       +1     
- Misses      17585    17606      +21     
Flag Coverage Δ
unittests 40.24% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rolan701 rolan701 merged commit e68e0e0 into hjkgrp:main Oct 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant