Bundle Windows ffmpeg integration for video thumbnails #324
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| function init() { | ||
| if (global.isWindows) { | ||
| const bundledPath = resolveBundledFfmpeg(); | ||
| if (bundledPath) { | ||
| setFfmpegBinary(bundledPath); | ||
| } else { | ||
| logger.error('[video-thumbnail] Windows environment detected but no ffmpeg.exe bundled'); | ||
| global._has_ffmpeg_ = false; |
There was a problem hiding this comment.
[P1] Fallback skips system ffmpeg on Windows
When init() runs on Windows and the bundled resource/ffmpeg/ffmpeg.exe is missing, the code only logs an error and sets _has_ffmpeg_ to false. It never attempts to use a system-wide ffmpeg from the PATH. As a result, video GIF generation is permanently disabled on Windows machines unless users copy an executable into the resource folder, even though the commit description claims the service should “fall back gracefully when missing”. Consider invoking setFfmpegBinary('ffmpeg') after the bundled lookup fails so installations with a pre-installed ffmpeg keep working.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68da63a33cf883258517611154e16fce