Skip to content

Conversation

@jayudoye
Copy link

@jayudoye jayudoye commented Mar 1, 2025

Pull Request

Description

This pull request adds a feature that allows and enables a user with authentication to delete a Squeeze record in the database of hng_boilerplate_nestjs repository. The update of the feature includes:

  • Fixing errors in the deleteSqueeze method.
  • Implementing proper authentication checks before deletion.
  • Improving exception handling with more meaningful error messages.
  • Adding test cases for the delete operation.

Related Issue

This PR is related to the issue #1291

Fixes #(issue)

  • Corrected the check for authenticatedSqueezeId before deletion.
  • Added proper exception handling using CustomHttpException.

Type of Change

  • feat: New feature
  • fix: Bug fix
  • docs: Documentation updates
  • style: Code style/formatting changes
  • refactor: Code refactoring
  • perf: Performance improvements
  • test: Test additions/updates
  • chore: Build process or tooling changes
  • ci: CI configuration changes

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests

Test Evidence

  • Sending a DELETE request to /api/v1/squeeze using Postman.
  • Appropriate error messages returned

Checklist

  • My code follows the project's coding style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have included a screenshot showing all tests passing
  • I have included documentation screenshots (if applicable)

@jayudoye jayudoye changed the title feat: squeeze record deletion feat: add squeeze record deletion endpoint Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant