-
Notifications
You must be signed in to change notification settings - Fork 61
Fixed migration and seeding issues, resolved foreign key constraints #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cyrilmano
wants to merge
4
commits into
hngprojects:dev
Choose a base branch
from
cyrilmano:fix/migration-seeding-errors
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
49a026d
Fixed migration and seeding issues, resolved foreign key constraints
cyrilmano 1cc3625
Revert composer.lock to previous version from commit e91586b
cyrilmano 27be0d1
Comment out foreign key checks in seeders to prevent potential issues…
cyrilmano a2f236c
Refactor email sending tests and update variables column type in emai…
cyrilmano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
.../2025_03_02_214711_change_variables_column_from_jsonb_to_text_in_email_requests_table.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <?php | ||
|
|
||
| use Illuminate\Database\Migrations\Migration; | ||
| use Illuminate\Database\Schema\Blueprint; | ||
| use Illuminate\Support\Facades\Schema; | ||
|
|
||
| return new class extends Migration | ||
| { | ||
| /** | ||
| * Run the migrations. | ||
| */ | ||
| public function up(): void | ||
| { | ||
| Schema::table('email_requests', function (Blueprint $table) { | ||
| $table->text('variables')->nullable()->change(); | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * Reverse the migrations. | ||
| */ | ||
| public function down(): void | ||
| { | ||
| Schema::table('email_requests', function (Blueprint $table) { | ||
| $table->jsonb('variables')->nullable()->change(); | ||
| }); | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,35 +83,35 @@ public function test_it_returns_validation_errors_for_invalid_data() | |
|
|
||
| public function test_job_sends_emails() | ||
| { | ||
| // Create a template | ||
| $template = EmailTemplate::create([ | ||
| 'id' => (string) \Illuminate\Support\Str::uuid(), | ||
| 'title' => 'Welcome Template', | ||
| 'template' => '<p>Hello {{name}},</p><p>Welcome to our service!</p>', | ||
| 'status' => true, | ||
| ]); | ||
|
|
||
| // Create an email request | ||
| $request = EmailRequest::create([ | ||
| 'id' => (string) \Illuminate\Support\Str::uuid(), | ||
| 'template_id' => $template->id, | ||
| 'subject' => 'Test Subject', | ||
| 'recipient' => '[email protected]', | ||
| 'variables' => '{"name": "John Doe"}', | ||
| 'status' => 'pending', | ||
| ]); | ||
|
|
||
| SendEmailRequestsJob::dispatch(); | ||
|
|
||
| // Assert the email was sent | ||
| Mail::assertSent(EmailRequestMailable::class, function (EmailRequestMailable $mail) use ($request) { | ||
| return $mail->hasTo($request->recipient) && | ||
| $mail->subject === $request->subject && | ||
| $mail->htmlContent === '<p>Hello John Doe,</p><p>Welcome to our service!</p>'; | ||
| }); | ||
|
|
||
| $request->refresh(); | ||
| $this->assertEquals('sent', $request->status); | ||
| // Create a template | ||
| $template = EmailTemplate::create([ | ||
| 'id' => (string) \Illuminate\Support\Str::uuid(), | ||
| 'title' => 'Welcome Template', | ||
| 'template' => '<p>Hello {{name}},</p><p>Welcome to our service!</p>', | ||
| 'status' => true, | ||
| ]); | ||
|
|
||
| // Create an email request | ||
| $request = EmailRequest::create([ | ||
| 'id' => (string) \Illuminate\Support\Str::uuid(), | ||
| 'template_id' => $template->id, | ||
| 'subject' => 'Test Subject', | ||
| 'recipient' => '[email protected]', | ||
| 'variables' => '{"name": "John Doe"}', | ||
| 'status' => 'pending', | ||
| ]); | ||
|
|
||
| SendEmailRequestsJob::dispatch(); | ||
|
|
||
| // Assert the email was sent | ||
| Mail::assertSent(EmailRequestMailable::class, function (EmailRequestMailable $mail) use ($request) { | ||
| return $mail->hasTo($request->recipient) && | ||
| $mail->subject === $request->subject && | ||
| $mail->htmlContent === '<p>Hello John Doe,</p><p>Welcome to our service!</p>'; | ||
| }); | ||
|
|
||
| $request->refresh(); | ||
| $this->assertEquals('sent', $request->status); | ||
| } | ||
|
|
||
| public function test_job_logs_error_when_email_sending_fails() | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.