Skip to content

Conversation

@lmaertin
Copy link
Contributor

@lmaertin lmaertin commented Oct 27, 2025

Breaking change

Proposed change

bump to python-pooldose 0.7.8, added additional sensor desc with strings/icons and updated fixture/testcases

API-Changes Version: 0.7.0 - 0.7.8

New Features

  • CLI Debug Flag: --print-payload for HTTP payload debugging
  • Payload Inspection: Added debug_payload parameter and get_last_payload() method
  • Client Convenience Methods: Direct set_switch, set_number, set_select methods

Improvements

  • Fixed strict datatypes for all API calls (latest 0.7.8 change)
  • Array-Based Payloads: Consistent format for all operations: [{"value": 7, "type": "NUMBER"}]
  • New Device Support: VA DOS EXACT (Model PDPR1H1HAR1V1, FW FW539224) --- RELEVANT for HA integration
  • Bug Fix: Removed unsupported Chlorine Sensor from PDPR1H1HAR1V0 --- RELEVANT for HA integration

Full changelog: lmaertin/python-pooldose@0.7.0...0.7.8

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the python-pooldose library from version 0.7.0 to 0.7.7, incorporating support for a new device model (VA DOS EXACT) and addressing an API bug that incorrectly included a chlorine sensor for certain models. The update adds new sensor descriptions for chlorine and flow rate measurements, includes dynamic unit handling for flow rate sensors, and corrects sensor key naming inconsistencies.

Key changes:

  • Library version bump from 0.7.0 to 0.7.7
  • Added chlorine and flow rate sensor support with appropriate translations and icons
  • Fixed sensor key naming from ofa_ph_value/ofa_orp_value to ofa_ph_time/ofa_orp_time

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
homeassistant/components/pooldose/manifest.json Updated python-pooldose requirement to 0.7.7
homeassistant/components/pooldose/sensor.py Added chlorine and flow rate sensor descriptions, fixed sensor key naming, implemented dynamic unit handling for flow rate
homeassistant/components/pooldose/strings.json Added translations for new chlorine and flow rate sensors, updated sensor key references
homeassistant/components/pooldose/icons.json Added icons for new sensors, updated key references
tests/components/pooldose/fixtures/instantvalues.json Added test data for new sensors, updated sensor keys to match API changes
tests/components/pooldose/test_sensor.py Added test for flow rate sensor dynamic unit handling
tests/components/pooldose/snapshots/test_sensor.ambr Updated snapshots to reflect new sensors and corrected keys
requirements_all.txt Updated python-pooldose version to 0.7.7
requirements_test_all.txt Updated python-pooldose version to 0.7.7

@lmaertin lmaertin changed the title Bump Pooldose API to 0.7.6 Bump Pooldose API to 0.7.8 Oct 27, 2025
Copy link
Member

@abmantis abmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lmaertin !

Lets keep the dependency bump in one PR and move all changes that are not strictly required for the bump to a separate PR please, as noted in point 7 of our Review Process documentation.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 27, 2025 21:49
@lmaertin
Copy link
Contributor Author

Hey @lmaertin !

Lets keep the dependency bump in one PR and move all changes that are not strictly required for the bump to a separate PR please, as noted in point 7 of our Review Process documentation.

Ok, ich will re-create this PR with minimal content on the bump and prepare a 2nd PR for the new features for the sensor platform

@lmaertin
Copy link
Contributor Author

re-created as minimal PR #155307

@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants