-
-
Couldn't load subscription status.
- Fork 35.7k
Bump Pooldose API to 0.7.8 #155295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Pooldose API to 0.7.8 #155295
Conversation
…ngs/icons and updated fixture/testcases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the python-pooldose library from version 0.7.0 to 0.7.7, incorporating support for a new device model (VA DOS EXACT) and addressing an API bug that incorrectly included a chlorine sensor for certain models. The update adds new sensor descriptions for chlorine and flow rate measurements, includes dynamic unit handling for flow rate sensors, and corrects sensor key naming inconsistencies.
Key changes:
- Library version bump from 0.7.0 to 0.7.7
- Added chlorine and flow rate sensor support with appropriate translations and icons
- Fixed sensor key naming from
ofa_ph_value/ofa_orp_valuetoofa_ph_time/ofa_orp_time
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/pooldose/manifest.json | Updated python-pooldose requirement to 0.7.7 |
| homeassistant/components/pooldose/sensor.py | Added chlorine and flow rate sensor descriptions, fixed sensor key naming, implemented dynamic unit handling for flow rate |
| homeassistant/components/pooldose/strings.json | Added translations for new chlorine and flow rate sensors, updated sensor key references |
| homeassistant/components/pooldose/icons.json | Added icons for new sensors, updated key references |
| tests/components/pooldose/fixtures/instantvalues.json | Added test data for new sensors, updated sensor keys to match API changes |
| tests/components/pooldose/test_sensor.py | Added test for flow rate sensor dynamic unit handling |
| tests/components/pooldose/snapshots/test_sensor.ambr | Updated snapshots to reflect new sensors and corrected keys |
| requirements_all.txt | Updated python-pooldose version to 0.7.7 |
| requirements_test_all.txt | Updated python-pooldose version to 0.7.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lmaertin !
Lets keep the dependency bump in one PR and move all changes that are not strictly required for the bump to a separate PR please, as noted in point 7 of our Review Process documentation.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Ok, ich will re-create this PR with minimal content on the bump and prepare a 2nd PR for the new features for the sensor platform |
|
re-created as minimal PR #155307 |
Breaking change
Proposed change
bump to python-pooldose 0.7.8, added additional sensor desc with strings/icons and updated fixture/testcases
API-Changes Version: 0.7.0 - 0.7.8
New Features
--print-payloadfor HTTP payload debuggingdebug_payloadparameter andget_last_payload()methodset_switch,set_number,set_selectmethodsImprovements
[{"value": 7, "type": "NUMBER"}]Full changelog: lmaertin/python-pooldose@0.7.0...0.7.8
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: